fix(predict): prevent buy/sell sheet from being cropped in HomepageDiscoveryTabs cp-7.78.0 by vinnyhoward · Pull Request #30219 · MetaMask/metamask-mobile

vinnyhoward · 2026-05-14T22:45:10Z

Description

When PredictFeed is rendered inside HomepageDiscoveryTabs (behind the coreMCU589AbtestHubPageDiscoveryTabs A/B test), the PredictPreviewSheetProvider bottom sheet is cropped by the tab layout and unusable.

Changes:

Added disableBottomSheet prop to PredictPreviewSheetProvider — when true, openBuySheet/openSellSheet navigate to the full-screen bet slip instead of opening the sheet
Fixed isPredictSheetProviderMounted to return false in navigate mode, preventing silent order failures (toast was suppressed but sheet never reopened)
Added beforeRemove listener to PredictBuyPreview for swipe/hardware-back dismiss tracking in screen mode — previously only back-button dismissals were tracked on the non-AnyToken path

Changelog

CHANGELOG entry:null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-752

Manual testing steps

Feature: Predict buy sheet in HomepageDiscoveryTabs

  Scenario: user opens a prediction from the Predictions tab
    Given the coreMCU589AbtestHubPageDiscoveryTabs flag is set to treatment
    And the user is on the Predictions tab

    When user taps a prediction outcome
    Then the full-screen buy preview opens instead of a bottom sheet

  Scenario: order fails in the background with disableBottomSheet enabled
    Given the user opened and dismissed the buy preview
    When the order fails in the background
    Then a failure toast is shown

Screenshots/Recordings

fixed.mov

Before

broken.mov

After

fixed.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
I've tested with a power user scenario
- Use these power-user SRPs to import wallets with many accounts and tokens
I've instrumented key operations with Sentry traces for production performance metrics
- See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes Predict bet slip presentation and navigation (sheet vs full-screen) plus dismissal/toast tracking logic, which could affect order-failure UX and analytics in core Predict flows.

Overview
Prevents the Predict buy/sell bottom sheet from being unusable inside HomepageDiscoveryTabs by adding a disableBottomSheet mode to PredictPreviewSheetProvider that always navigates to the full-screen buy/sell previews.

Updates isPredictSheetProviderMounted() to only report mounted when the provider is actually in sheet mode (avoiding suppression of legacy failure toasts when navigating instead), and adjusts navigation calls to use nested Routes.PREDICT.ROOT + screen params.

Adds screen-mode betslip dismissal analytics by registering a beforeRemove listener in PredictBuyPreview to classify swipe vs back-button dismissals, with accompanying test coverage and wiring HomepageDiscoveryTabs to pass disableBottomSheet for the Predictions tab.

^{Reviewed by Cursor Bugbot for commit 3ee59d2. Bugbot is set up for automated code reviews on this repo. Configure here.}

…page tabs

github-actions · 2026-05-14T22:45:19Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

vinnyhoward · 2026-05-14T22:45:24Z

-   */
-  const clearErrorTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
+  const dismissedWithErrorRef = useRef(false);



Navigate via ROOT so the screen resolves correctly

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4585d39. Configure here.}

…k-button state

…mcu-752-predict-sheet-homepage-discovery-tabs

github-actions · 2026-05-15T14:08:10Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokePredictions, SmokeWalletPlatform, SmokeConfirmations
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 88%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are focused on the Predictions (Polymarket) feature with three key modifications:

PredictPreviewSheetContext.tsx: Added disableBottomSheet prop that changes navigation routing from direct modal navigation (Routes.PREDICT.MODALS.BUY_PREVIEW) to nested navigation (Routes.PREDICT.ROOT → screen: BUY_PREVIEW). Also updated isPredictSheetProviderMounted() to return false when in non-sheet mode. This is a behavioral change in how the buy/sell preview flows are navigated to.
PredictBuyPreview.tsx: Refactored dismiss tracking analytics - moved swipe/hardware-back dismissal tracking to a beforeRemove navigation listener for screen mode, while sheet mode retains its own tracking. Also resets predictBuyPreviewDismissedViaBackRef on mount to prevent state bleed between sessions.
HomepageDiscoveryTabs.tsx: Passes disableBottomSheet to PredictPreviewSheetProvider in the Predictions tab within the Hub Page Discovery Tabs A/B test layout. This means when Predict is rendered inside the tab layout, it navigates to full-screen instead of opening a bottom sheet.

Tag selection rationale:

SmokePredictions: Directly affected - the buy/sell preview navigation flow, dismiss tracking, and sheet provider behavior are all changed. E2E tests need to verify the full position lifecycle still works correctly with the new navigation routing.
SmokeWalletPlatform: Required per SmokePredictions tag description ("also select SmokeWalletPlatform - Trending section"). HomepageDiscoveryTabs.tsx is directly modified, affecting the Trending/Discovery tab where Predictions is embedded.
SmokeConfirmations: Required per SmokePredictions tag description ("also select SmokeConfirmations - opening/closing positions are on-chain transactions"). The buy preview flow leads to on-chain transactions.

No other tags are impacted - changes are isolated to Predictions UI/navigation logic with no effects on accounts, networks, swaps, browser, snaps, or other features.

Performance Test Selection:
No performance-impacting changes. The modifications are focused on navigation routing logic (bottom sheet vs full-screen navigation), analytics tracking refactoring, and a prop addition. There are no changes to list rendering, data loading, state management, app startup, or other performance-sensitive areas.

View GitHub Actions results

sonarqubecloud · 2026-05-15T14:27:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix: bypass bottom sheet navigation for bet slip when rendered in hub…

4585d39

…page tabs

vinnyhoward requested review from a team as code owners May 14, 2026 22:45

vinnyhoward commented May 14, 2026

View reviewed changes

cursor Bot reviewed May 14, 2026

View reviewed changes

Comment thread app/components/UI/Predict/views/PredictBuyPreview/PredictBuyPreview.tsx

vinnyhoward added 2 commits May 14, 2026 16:56

fix(predict): reset dismissedViaBackRef on mount to prevent stale bac…

af84d0b

…k-button state

Merge branch 'main' of github.com:MetaMask/metamask-mobile into fix-t…

3ee59d2

…mcu-752-predict-sheet-homepage-discovery-tabs

github-actions Bot added the size-M label May 15, 2026

vinnyhoward added team-mobile-ux Mobile UX team team-predict Predict team labels May 15, 2026

vinnyhoward changed the title ~~fix(predict): prevent buy/sell sheet from being cropped in HomepageDiscoveryTabs~~ fix(predict): prevent buy/sell sheet from being cropped in HomepageDiscoveryTabs cp-7.78.0 May 15, 2026

wachunei approved these changes May 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(predict): prevent buy/sell sheet from being cropped in HomepageDiscoveryTabs cp-7.78.0#30219

fix(predict): prevent buy/sell sheet from being cropped in HomepageDiscoveryTabs cp-7.78.0#30219
vinnyhoward wants to merge 3 commits into
mainfrom
fix-tmcu-752-predict-sheet-homepage-discovery-tabs

vinnyhoward commented May 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

vinnyhoward May 14, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

sonarqubecloud Bot commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vinnyhoward commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

vinnyhoward May 14, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 15, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented May 15, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vinnyhoward commented May 14, 2026 •

edited

Loading